Implement OAuth token caching and processing#78
Open
togelashvili-tbc wants to merge 2 commits into
Open
Conversation
togelashvili-tbc
force-pushed
the
feature/oauth-token-management
branch
from
July 24, 2026 12:44
1c868d2 to
3b840f2
Compare
togelashvili-tbc
changed the base branch from
feature/update-packages-0726-01
to
master
July 24, 2026 12:45
togelashvili-tbc
force-pushed
the
feature/oauth-token-management
branch
2 times, most recently
from
July 24, 2026 12:52
2bd26f7 to
0b15b81
Compare
togelashvili-tbc
marked this pull request as ready for review
July 24, 2026 13:06
togelashvili-tbc
force-pushed
the
feature/oauth-token-management
branch
from
July 24, 2026 13:28
0b15b81 to
a8ccf27
Compare
| } | ||
| #endif | ||
|
|
||
| services.AddDistributedMemoryCache(); |
There was a problem hiding this comment.
AI - მ გვითხრა ასეთი რამ და მგონი რომ მართალს ამბობს:
An SDK registering a process-wide in-memory IDistributedCache as a side effect is surprising and order-dependent (works only via TryAdd). At minimum, document it loudly on the method; better, make the fallback opt-in (registerFallbackCache: true) so we don't hijack the consumer's caching topology. Consumers running multi-instance who forget to register Redis would silently get non-shared caches and think it's working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.