Conversation
vincemolnar
left a comment
vincemolnar
left a comment
There was a problem hiding this comment.
The diffs demonstrate the correct implementation of the resolution. My comments all refer to problems that should have been addressed in the resolution - feel free to ignore them if they are out of scope.
| feature elements[0..*] ordered nonunique :>> Collection::elements; | ||
| doc | ||
| /* | ||
| * An OrderedCollection is a Collection of which the elements are ordered and not necessarily unique. |
There was a problem hiding this comment.
"of which the elements" sounds a bit awkward to me - changing it to "whose elements" or "in which elements" would make it read more natural. Feel free to ignore if it cannot be changed at this point. I will note other occurrences, though.
| } | ||
| doc | ||
| /* | ||
| * A UniqueCollection is a Collection of which the elements are unique and not necessarily ordered. |
There was a problem hiding this comment.
Same wording ("of which")
| */ | ||
|
|
||
| feature elements[0..*] :>> Collection::elements { | ||
| doc |
There was a problem hiding this comment.
This was not a doc comment, and it does not look like documentation. Are you sure it shouldn't stay a simple comment?
|
|
||
| doc | ||
| /* | ||
| * An Array is a fixed size, multi-dimensional Collection of which the elements are nonunique and ordered. |
| * Feature elements is a flattened sequence of all elements of an Array and can be accessed by a tuple of indices. | ||
| * The number of indices is equal to rank. The elements are packed according to row-major convention. | ||
| * | ||
| * The elements of an Array can be assessed by a tuple of indices. The number of indices in such tuple is equal to rank. |
There was a problem hiding this comment.
"assessed" should probably be "accessed", but this was probably not reported in the issue.
| datatype List :> OrderedCollection { | ||
| doc | ||
| /* | ||
| * A List is a variable-size Collection of which the elements are nonunique and ordered. |
| */ | ||
|
|
||
| feature elements[0..*] ordered :>> OrderedCollection::elements, UniqueCollection::elements { | ||
| doc |
There was a problem hiding this comment.
Was not a doc comment before
| */ | ||
|
|
||
| feature elements: KeyValuePair[0..*] :>> Collection::elements { | ||
| doc |
There was a problem hiding this comment.
Was not a doc comment before
| /* Note: Redefinition of `elements` is unique by default. */ | ||
| } | ||
| feature elements: KeyValuePair[0..*] ordered :>> Map::elements, OrderedCollection::elements { | ||
| doc |
There was a problem hiding this comment.
Was not a doc comment before
| doc | ||
| /* | ||
| * A KeyValuePair is a DataValue that represents a pair of a key and an associated val, |
There was a problem hiding this comment.
Shouldn't "val" be "value" in the documentation?
2 participants
This PR updates the KerML library model files
Transfer::isInstantandCollectionsper the resolutions to the following issues approved on KerML 1.1 RTF Ballot 2. Note that both issues primarily require updates to documentation, except as noted below.Note. The resolution to this issue includes two functional changes to
Collections.kerml:Map.OrderCollectiontoOrderedMap.The resolution to the following issue also approved on Ballot 2 was already proactively implemented in PR #660 (ST6RI-859).