Skip to content

Potential bug fix for issue #3 re case-only directory name changes. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveIves wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Potential bug fix for issue #3 re case-only directory name changes. #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion SFTPSyncLib/RemoteSync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ private static async Task CreateDirectoriesInternal(
return item.Name.Remove(item.Name.IndexOf(".DIR", StringComparison.OrdinalIgnoreCase));
else
return item.Name;
});
}, StringComparer.OrdinalIgnoreCase);

foreach (var item in localDirectories)
{
Expand Down Expand Up @@ -741,6 +741,14 @@ private async void Fsw_DirectoryRenamed(object? sender, RenamedEventArgs arg)
var oldRemotePath = GetRemotePathForLocal(arg.OldFullPath);
var newRemotePath = GetRemotePathForLocal(arg.FullPath);

// OpenVMS directory names preserve case but are case-insensitive. A case-only
// local rename therefore refers to the same remote directory and needs no action.
if (string.Equals(oldRemotePath, newRemotePath, StringComparison.OrdinalIgnoreCase))
{
Logger.LogInfo($"Ignoring case-only directory rename: {oldRemotePath} -> {newRemotePath}");
return;
}

await _sftpLock.WaitAsync();
try
{
Expand Down
Loading