Fix: Ensure memory-layout safety in Linux clock interception - #8
Open
mertcano wants to merge 1 commit into
Open
Conversation
### Description This PR addresses High-severity memory layout issues in the `deterministic-simulator` repository, as identified in the workspace-wide security audit. **Vulnerabilities & Security Defects Remediated:** * **Clock Interceptor Memory Safety (`msim/src/sim/time/mod.rs`):** The Linux monotonic-clock path previously transmuted the opaque `std::time::Instant` representation directly into `libc::timespec`. This is not a stable ABI contract and failed with invalid timestamps under current Rust toolchains. The interceptor now safely and explicitly serializes the simulated duration directly into the `tv_sec` and `tv_nsec` fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses High-severity memory layout issues in the
deterministic-simulatorrepository, as identified in the workspace-wide security audit.Vulnerabilities & Security Defects Remediated:
msim/src/sim/time/mod.rs): The Linux monotonic-clock path previously transmuted the opaquestd::time::Instantrepresentation directly intolibc::timespec. This is not a stable ABI contract and failed with invalid timestamps under current Rust toolchains. The interceptor now safely and explicitly serializes the simulated duration directly into thetv_secandtv_nsecfields.