Skip to content

Align ci.yml with the canonical template exactly - #13

Merged
StuartMeeks merged 1 commit into
mainfrom
chore/align-ci-with-template
Aug 20, 2026
Merged

Align ci.yml with the canonical template exactly#13
StuartMeeks merged 1 commit into
mainfrom
chore/align-ci-with-template

Conversation

@StuartMeeks

Copy link
Copy Markdown
Owner

What changed

Removes the release job. ci.yml's non-comment content is now identical to templates/.github/workflows/ci.yml apart from the tag glob — which makes it identical to SelfUpdate's, verified by diff rather than by eye.

Why

This repo was the estate's only divergence from the canonical workflow, and I only noticed because you pushed back. Auth and SelfUpdate already matched the template — SelfUpdate exactly, Auth with one gnome-keyring step that has an EXCEPTIONS.md entry. That alignment was real and achieved. Settings sat outside it while the audit reported green, because §3.0 checks filenames, §3.1 checks job names, and nothing checked what actually runs.

Two earlier attempts at reconciling this made it worse, and both are reverted:

  1. Widening §3.1 to permit any tag-gated job downstream of publish — weakening a clause so a repo passes, which is the one thing the standards repo exists to stop.
  2. Folding the release steps into publish — kept the four job names and moved the divergence somewhere no check looked.

The job is simply gone.

Consumer impact

None. The job only ever ran on a v* tag, after the package had already been pushed to nuget.org. Publishing is untouched — same publish job, same trusted-publishing OIDC flow, same artifact.

The behaviour change is operational, not consumer-facing: GitHub releases for this package are now cut by hand, as they already were in all four other repos.

Enforcement

STANDARD.md §3.0.1 (in Standards) now requires this match, and audit-drift.sh has a 3.0.1 workflow content row that checks it.

Verified against both wrong attempts — with the release job, and with the folded steps, 3.0 and 3.1 stay PASS while 3.0.1 goes FAIL:

                        Auth    Auth.Providers  SelfUpdate  Settings  Splash
3.0   workflow file set  PASS       FAIL           PASS       PASS     FAIL
3.0.1 workflow content   PASS       FAIL           PASS       FAIL     FAIL   <-- before this PR
3.1   gate job `ci`      PASS       FAIL           PASS       PASS     FAIL

Checklist

  • Build is clean — no code changes
  • Tests pass on every shipped target framework — unchanged; CI proves it on this PR
  • Public API changes carry XML docs — none
  • CHANGELOG.md updated under [Unreleased]
  • Dependency floors unchanged

🤖 Generated with Claude Code

Removes the `release` job. ci.yml's non-comment content is now identical
to templates/.github/workflows/ci.yml apart from the tag glob, which
makes it identical to SelfUpdate's -- verified by diff, not by eye.

This repo was the estate's only divergence from the canonical workflow.
Auth and SelfUpdate already matched the template: SelfUpdate exactly,
Auth with one gnome-keyring step that has an EXCEPTIONS.md entry. That
alignment was real and achieved, and this repo was quietly outside it
while the audit reported green, because 3.0 checks filenames and 3.1
checks job names and nothing checked what actually runs.

Two earlier attempts at this made it worse. The first widened 3.1 to
permit any tag-gated job downstream of `publish` -- weakening a clause so
a repo passes, which is the one thing the standards repo exists to stop.
The second folded the release steps into `publish`, which kept the four
job names and moved the divergence somewhere no check looked. Both are
reverted; the job is simply gone.

GitHub releases for this package are now cut by hand, as they already
were in all four other repos. No consumer impact: the job only ever ran
on a v* tag, after the package had already been pushed to nuget.org.
Publishing is untouched.

STANDARD.md 3.0.1 now requires this match and audit-drift.sh checks it.
Verified against both wrong attempts: with the release job, and with the
folded steps, 3.0 and 3.1 stay PASS while 3.0.1 goes FAIL.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@StuartMeeks
StuartMeeks merged commit 6d496fc into main Aug 20, 2026
9 checks passed
@StuartMeeks
StuartMeeks deleted the chore/align-ci-with-template branch August 20, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant