chore: move the package-validation baseline to 1.0.1 - #35
Merged
Conversation
1.0.1 is published, so it is now the last shipped release and the correct surface to validate against. From here an accidental public-API break fails the build against the first stable release rather than against 0.3.1, which makes a break a 2.0.0 rather than a judgement call. There is no 1.0.0 to baseline against: it was merged but never tagged, so it was never published. This could not land until nuget.org finished indexing. The baseline makes the build RESTORE that package, so pointing it at a version the feed cannot serve fails with NU1102 — verified: the first attempt failed with "Nearest version: 0.3.1" before indexing completed, and again afterwards from a stale local http-cache until it was cleared. Release build: 0 warnings, validation green against the published 1.0.1. 410 tests (205 × net8.0/net10.0) pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0.1 is published, so it is now the last shipped release and the correct surface for
EnablePackageValidationto compare against.Why it matters
The baseline was
0.3.1, which was correct while 1.0.1 was unpublished. It no longer is — leaving it there means an accidental break in the public surface would be measured against a pre-1.0 release, where breaking changes were expected. Against1.0.1a break fails the build, which is what makes "a break requires 2.0.0" an enforced rule rather than a judgement call.There is no 1.0.0 to baseline against: it was merged but never tagged, so it was never published.
Ordering constraint, hit for real
PackageValidationBaselineVersionmakes the build restore that package, so it can only point at a version the feed can actually serve. This failed twice before it worked, both verified rather than assumed:http-cache, until that was cleared.Committing this blind would have passed on a warm cache and failed CI on a clean runner.
Verification
Release build: 0 warnings, 0 errors, with package validation resolving and comparing against the published
1.0.1.dotnet test --configuration Release: 410 passed, 0 failed (205 ×net8.0/net10.0).No version bump and no source change —
<Version>stays1.0.1; this only moves what the build validates against.🤖 Generated with Claude Code