Update StrEnum to v2.1.0. Add integration tests for string enums in composite primary keys. - #9
Merged
Conversation
…omposite primary keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IComparable<TEnum>,IComparable, andIEquatable<TEnum>toStringEnum<TEnum>, letting a string enum be used as an EF Core key or as part of a composite key.StrEnum.EntityFrameworkCore.IntegrationTestsproject, following the*.IntegrationTestsconvention already used across the ecosystem. It runs against SQLite in memory, so it needs no Docker and runs as part of the existing Dockertesttarget.CompositePrimaryKeyTests, covering a string enum as part of a composite primary key: the model shape, a full round-trip through insert,FindAsyncon the composite key, update and query, and a raw-SQL check that the key column holds the member's value.Test plan
dotnet test— 11 unit and 3 integration tests passdocker build --target test .— the CI path passes with the new project wired into the solution and the Dockerfile restore layer