Pin scb-check 0.1.3 and remove legacy slop rules - #21
Open
Mike-7777777 wants to merge 3 commits into
Open
Conversation
The composite quality scores come from `uvx scb-check`, which had no version constraint, so verbosity was computed by whatever release uvx resolved at run time. On a fixed input, scb-check 0.1.3 reports 2.42x the verbosity of 0.1.0/0.1.1/0.1.2/0.2.0; erosion is unaffected. Pin the version at the call site and store it under scb_check_version on every checkpoint that scb-check successfully measured, so results stay comparable and past runs stay interpretable. Checkpoints where scb-check fails keep their existing behaviour and record no version.
gabeorlanski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
What changed
uvx scb-check==0.1.3and recordscb_check_versionin checkpoint metrics.scb-checkreport as the sole source for verbosity, erosion, clone, and flagged-LOC checkpoint metrics.scb-checkverbosity metrics.scb-checkpath.scb-check==0.1.3command and recorded version.Validation
uv run pytest -q tests/metrics tests/dashboard/graphs/scatter_test.py tests/entrypoints/commands/test_variance.py tests/entrypoints/commands/test_backfill_reports.py— 482 passed.slop-code:python3.12Docker image is unavailable (exit 125).git diff --check— clean.