Fix landing page animation resource leak on navigation - #74
Open
google-labs-jules[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a critical performance and resource leak where the landing page canvas background animation continues to run indefinitely in the background after a user navigates to another route (such as CV, publications, or projects).
Why This Is Necessary (Rationale)
The interactive landing page animation relies on a recursive
requestAnimationFrameloop that starts after a initial 400ms delay. Previously, the cleanup function returned by Svelte'sonMountinsrc/routes/+page.svelteonly disconnected the layoutResizeObserver.Because it failed to clear the scheduled
setTimeoutand activerequestAnimationFrameprocesses, the animation cycles continued to run invisibly on subpages. This caused substantial, unnecessary CPU/GPU load, resulting in quick battery drain and thermal throttling—especially on mobile devices.By tracking and explicitly canceling both the pending timeout and the active frame rendering, we eliminate these background tasks completely, restoring baseline resource utilization when browsing subpages.
Key Decisions & Changes
requestAnimationFrame).onMountcleanup return function to:clearTimeoutif the user leaves before 400ms.cancelAnimationFrame.ResizeObserver.disconnect()).Verification & Acceptance Criteria