chore: drop the develop branch from CI triggers - #160
Merged
Conversation
The develop branch is deleted. It carried no commits that main did not already have, everything ships from main through tags, and it was the one branch no ruleset covered -- push, force-push and delete were all unrestricted on it for every collaborator with write, silently, because `protect_main` targets `~DEFAULT_BRANCH` and can never match anything else. That leaves the push and pull_request triggers naming a ref that cannot exist, and a dispatch example telling a reader to run against it. Point the example at main and note that a tag works too, which is the case worth reaching for anyway -- checking what a release actually built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
developis deleted. It carried zero commits thatmaindid not already have, everything ships frommainthrough tags, and no open PR targeted it.It was also the one branch no rule covered.
protect_mainscopes itself with:That is a pointer to the default branch, so it could never match
developno matter how the repository evolved — andrules/branches/develop(which reports org-inherited rules too) came back empty. Every collaborator withwritecould push directly, force-push to rewrite history, or delete the branch, and none of it would produce a notification.What changes
Only the trigger block.
pushandpull_requestnamed a ref that can no longer exist, and the dispatch example told a reader to run against it.The example now points at
main, and mentions that a tag works too — which is the case actually worth reaching for, since it answers "what did that release really build?"Verification