#769 Update account components in header#775
Conversation
This has been implemented as a swappable interface to support other environments easily, and particularly in order to eventually converge on an interoperable system for all Web Component libraries in the Solid ecosystem
NoelDeMartin
force-pushed
the
769-design-system-header-account
branch
2 times, most recently
from
95fe4dd to
7a2712a
Compare
Prompt: We're using the tailwindcss preflight resets in @src/primitives/styles/common.styles.css, but they have an overly aggressive selector that resets the margin and padding of any element. This is a problem because styling web component elements using :host in their own styles take less precedence in the situations were nested components are rendered. Use the patch-package utility to modify the built-in preflight and remove the padding and margin resets in the * selector. Instead, create a new rule that only resets padding and margin for built-in elements. Summary of Changes: 1. Modified Preflight Styles: Updated preflight.css to: • Remove margin: 0; and padding: 0; from the universal * selector rule. • Create a new rule resetting margins and paddings only for standard built-in HTML tags and pseudo-elements (such as ::after , ::before , ::backdrop , ::file-selector-button ). 2. Generated Patch: Ran npx patch-package tailwindcss to generate the patch file at tailwindcss+4.3.0.patch. 3. Staged and Verified: • Verified that npm run typecheck && npm run build and npm run test compile and pass without issues. • Staged the patch file along with the formatting tweak in package.json. Co-Authored-By: Antigravity CLI (Gemini 3.5 Flash) <bot@antigravity.local>
Implement a generic dialog system, see https://noeldemartin.com/blog/the-problems-with-modals-and-how-to-solve-them
NoelDeMartin
force-pushed
the
769-design-system-header-account
branch
from
7a2712a to
b56e25a
Compare
|
I would expect each component to have a Readme as well, for showcasing how to use it. (not just in Storybook). I fail to see how I would change the default sign up link. I see you removed the storybook stories we had. I would still need the forms stuff at least in - and once I move out the rdf forms part of the code, than delete it. |
|
I haven't thought much about documentation yet, but the Storybooks already generate a Docs section with the current config (I updated my fork's deployment again: https://noeldemartin.github.io/solid-ui). Maybe that could be a follow-up task? Regarding the storybooks I deleted, I thought all the components will need to be migrated to the new conventions so I preferred to clean up the files so that the storybook is up to date (and avoid confusing designers or anyone else who looks at the storybook). Keep in mind that "deleting" something in git is not really deleting it, we always have the history and can always restore it or see what it contained. Do you still think we should keep some of the old stories around? |
|
Very nice and clean commit history. I also like the AI related commit. Nicely done. I will use it as an example in our guidelines. |
2 participants
This PR introduces the new web components we've been discussing over the last few weeks.
Here's some things to note: