Fix wrong color ordering.#57
Open
justushelo wants to merge 7 commits into
Open
Conversation
Contributor
justushelo
commented
Jun 5, 2026
justushelo
commented
- Fix color ordering with Python workflow and dashboard.
- Add tests to ensure correct ordering of color and shades.
- Update structural_reliability.ipynb with correct colors.
- Add heterogeneity indices function. - Add functionality for printing indices and legend. sensitivity_indices.py edited to get var_names for printing. - Added guardrails for output parameter in decomposition.py - Added tests for printing legend. - Initialize decomposition in dashboard with 0.8*sum(si). Other variables still can be chosen after this. - Updated docs to print correct second-order effects. Closes Simulation-Decomposition#46, Closes Simulation-Decomposition#47
- Remove decomposition guardrail. - Use one print for print_indices. - Add typing info to visualization.py - Specify decomposition in visualization.py - Add Ipython into pyproject.toml and add guardrail for import. - Add stacklevel=2 into warnings. - Make a function for plotting heterogeneity indices. - Work with ax instead of plt. - Delete unnecessary +. - Add logging instead of print in heterogeneity_indices.py. - Set import order correct. Closes Simulation-Decomposition#46, Closes Simulation-Decomposition#47.
- Combine if/elif structure in visualization.py. - Add more descriptive ipython dependency into pyproject.toml. - Add test for two_visualization_output if decomposition is missing. - Correct import order. Closes Simulation-Decomposition#46, Closes Simulation-Decomposition#47
- Fix two_output_visulalization order. - Edit heterogeneity_indices plot title to include heterogeneity indice value. - Fix heterogeneity_indices test to fit title logic.
- Fix color ordering with Python workflow and dashboard. - Add tests to ensure correct ordering of color and shades. - Update structural_reliability.ipynb with correct colors.
✅ Deploy Preview for simdec-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tupui
approved these changes
Jun 5, 2026
Member
tupui
left a comment
tupui
left a comment
There was a problem hiding this comment.
The diff is puzzling as I thought I already reviewed this but ok I see Mariia validated the outcome so let's get this in.
Member
|
Oh I see we have a merge conflicts. Pls merge main into your branch locally |
tupui
reviewed
Jun 6, 2026
| return np.asarray(si).flatten() | ||
|
|
||
|
|
||
| def explained_variance_80(sensitivity_indices_table): |
Member
There was a problem hiding this comment.
So no 80% anymore? The function's naming is not proper anymore then.
| states=res.states, | ||
| bins=res.bins, | ||
| palette=palette, | ||
| palette=palette[::-1], |
Member
There was a problem hiding this comment.
Are you not inverting twice like this? The output of palette is inverted no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.