AutoDrive helper continuity - #28
Draft
SimGamerJen wants to merge 12 commits into
Draft
Conversation
Sync main into AutoDrive continuity branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoDrive helper continuity test branch based on main 2.1.0.0 plus the merged management UI fixes.
Root cause investigation showed that the earlier approaches were hooking the wrong lifecycle surfaces. V4 could not access AutoDriveStartStopEvent from HelperProfiles' runtime environment, while the existing HelperProfiles worker-appearance hook consistently receives the exact AutoDrive vehicle/helper pair through Enterable.setRandomVehicleCharacter(vehicle, helper).
V5 therefore uses HP_WorkerAppearance.vehicleAssignments as the authoritative vehicle-to-helper ownership signal. It does not depend on AutoDrive-private globals and does not guess ownership by scanning all mission vehicles.
V5 continuity flow:
HelperPayroll bridge:
Expected continuity diagnostics:
Expected payroll bridge diagnostics with HelperPayroll 0.4.3.0 Alpha 2 feature branch:
Normal HelperProfiles Selected/Next behaviour remains unchanged. This PR stays draft until the combined AutoDrive + Courseplay continuity/payroll test passes.