2.1.0: ship the unbenchmarked read-ahead hint off by default - #2
Merged
Conversation
A real 1.6.1170 session logged: opens=26162 patched=6481 no_buffering_stripped=0 The engine never set FILE_FLAG_NO_BUFFERING on that runtime, so the cache-restoring half of this plugin had nothing to do. That left FILE_FLAG_RANDOM_ACCESS as the only live effect - a caching hint that DISABLES the cache manager's read-ahead, where the FILE_FLAG_SEQUENTIAL_SCAN it displaces enlarges it. It has never been benchmarked as a win, and it was being applied to thousands of archive opens per minute. An unmeasured change at that rate is not a safe default, so Safe now ships bPreferRandomAccessOnArchives=0. Experimental keeps it on so the two can be A/B compared on the same save and route. Minimal is now behaviourally identical to Safe; documented rather than removed so existing installs keep working. No change to hook scope, safety gates, archive eligibility, or the DirectStorage backend (still disabled and not shipped). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A real 1.6.1170 session logged:
no_buffering_stripped=0means the engine never setFILE_FLAG_NO_BUFFERINGon that runtime, so the cache-restoring half of this plugin had nothing to do. That leftFILE_FLAG_RANDOM_ACCESSas the only live effect the plugin had - a caching hint that disables the cache manager's read-ahead, where theFILE_FLAG_SEQUENTIAL_SCANit displaces enlarges it. It has never been benchmarked as a win, and it was being applied to thousands of archive opens per minute.An unmeasured change at that rate is not a safe default.
What changed
bPreferRandomAccessOnArchives=0.What did not change
Hook scope, safety gates, archive eligibility rules, and the DirectStorage backend (still disabled and not shipped).
Validation
python tools/validate_rc.py-> VALIDATION PASSv2.1.0.🤖 Generated with Claude Code