Add rewriter option to erase generics#946
Open
dejmedus wants to merge 4 commits into
Open
Conversation
dejmedus
force-pushed
the
jb-erase-generic-types
branch
3 times, most recently
from
31c1d26 to
2146722
Compare
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dejmedus
force-pushed
the
jb-erase-generic-types
branch
from
2146722 to
b5fa3f7
Compare
dejmedus
changed the base branch from
graphite-base/946
to
jb-erase-generic-types-option
Sorbet erases generic types at runtime as they cannot be enforced. This means in runtime contexts we can drop generic types entirely, simplifying the rbs to sorbet signature translation This commit adds an `erase_generic_types` option to the `RBSCommentsToSorbetSigs` rewriter. When set, generic args are dropped from translated sigs (`Box[Integer]` to `Box`) and `extend T::Generic` is not added
Expose a flag to set the `erase_generic_types` option in `Spoom::Sorbet::Translate.rbs_comments_to_sorbet_sigs` so CLI users can drop generic types when translating from RBS to RBI
When erasing generic types we replace `type_member`s with a `T.anything` type alias of the same name. Qualifying `T.type_alias` to `::T.type_alias` ensures we avoid conflicts like `T = T.type_alias`. This matches
dejmedus
force-pushed
the
jb-erase-generic-types
branch
from
b5fa3f7 to
341e370
Compare
dejmedus
force-pushed
the
jb-erase-generic-types-option
branch
from
f95dbf3 to
0679934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorbet ignores generic types at runtime as they cannot be enforced. This means in runtime contexts we can drop generic types entirely, simplifying the RBS to Sorbet signature translation
This PR adds an
erase_generic_typesoption to theRBSCommentsToSorbetSigsrewriter and--erase-generic-types flagto CLI. When enabled genericFoo[Bar]will becomeFooand type members will become type aliases ofT.anything