Extract shared helpers for visibility-call processing#783
Merged
alexcrocha merged 1 commit intoJul 16, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 5, 2026
alexcrocha
force-pushed
the
05-04-support_array_and_inline-def_arguments_to_private_class_method
branch
from
May 6, 2026 00:59
d041f67 to
e17bd05
Compare
alexcrocha
force-pushed
the
05-04-extract_shared_helpers_for_visibility-call_processing
branch
2 times, most recently
from
May 7, 2026 04:11
0cd2420 to
da316e5
Compare
alexcrocha
force-pushed
the
05-04-support_array_and_inline-def_arguments_to_private_class_method
branch
from
May 7, 2026 04:11
e17bd05 to
cd8c5c3
Compare
alexcrocha
force-pushed
the
05-04-extract_shared_helpers_for_visibility-call_processing
branch
2 times, most recently
from
May 7, 2026 04:45
3cc7896 to
c668800
Compare
alexcrocha
force-pushed
the
05-04-support_array_and_inline-def_arguments_to_private_class_method
branch
2 times, most recently
from
May 7, 2026 22:45
48f55ed to
aa3c92e
Compare
alexcrocha
force-pushed
the
05-04-extract_shared_helpers_for_visibility-call_processing
branch
from
May 7, 2026 22:45
c668800 to
361d340
Compare
alexcrocha
changed the base branch from
05-04-support_array_and_inline-def_arguments_to_private_class_method
to
graphite-base/783
May 8, 2026 00:11
Each indexer backend parsed symbol and string arguments into a (name, location) pair in three places. The two visibility call sites can't reuse each_string_or_symbol_arg because they diagnose non-literal arguments instead of skipping them, so extract_literal_name returns an Option and lets each caller decide, and each_string_or_symbol_arg now builds on it.
alexcrocha
force-pushed
the
05-04-extract_shared_helpers_for_visibility-call_processing
branch
from
July 14, 2026 23:35
361d340 to
45edf22
Compare
alexcrocha
added
the
chore
alexcrocha
marked this pull request as ready for review
July 14, 2026 23:45
vinistock
reviewed
Jul 15, 2026
vinistock
approved these changes
Jul 16, 2026
alexcrocha
deleted the
05-04-extract_shared_helpers_for_visibility-call_processing
branch
July 16, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preceding stack (#780, #781, #782) built up the visibility-call repeated the same symbol and string argument parsing across the visibility-call handlers and
each_string_or_symbol_arg. This PR extracts that parsing intoextract_literal_name. The visibility handlers call it directly when they need custom handling for non-literal arguments, whileeach_string_or_symbol_argnow builds on it. No behaviour change.Both indexer backends (
RubyIndexerandRubyOperationBuilder) carry the duplication and get their own copy of the helper.