Skip to content

[Refactor] Simplify parseCommand control flow using guard clauses #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[Refactor] Simplify parseCommand control flow using guard clauses #8431

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7289d66
Refactor parseCommand to use early return guard clause
gonzaloriestra Aug 29, 2026
17636d1
Refactor parseCommand to use early return guard clause
gonzaloriestra Aug 29, 2026
5c0534a
Refactor parseCommand to use early return guard clause
gonzaloriestra Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/cli-kit/src/public/node/system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,16 +139,16 @@ function parseCommand(command: string): string[] {
for (const char of command) {
if (inQuote) {
if (char === inQuote) {
// End of quoted section
inQuote = null
} else {
current += char
}
} else if (char === '"' || char === "'") {
// Start of quoted section
continue
}

if (char === '"' || char === "'") {
inQuote = char
} else if (char === ' ' || char === '\t') {
// Whitespace outside quotes - end current token
if (current) {
result.push(current)
current = ''
Expand All @@ -158,7 +158,6 @@ function parseCommand(command: string): string[] {
}
}

// Don't forget the last token
if (current) {
result.push(current)
}
Expand Down
Loading