Add active-app-version deploy classification module

packages/app/src/cli/models/app/identifiers.test.ts

@@ -203,8 +203,7 @@ describe('getAppIdentifiers', () => {
       })
 
       // Then
-      expect(got.app).toEqual('FOO')
-      expect((got.extensions ?? {})['test-ui-extension']).toEqual('BAR')
+      expect(got['test-ui-extension']).toEqual('BAR')
     })
   })
 
@@ -229,8 +228,7 @@ describe('getAppIdentifiers', () => {
       )
 
       // Then
-      expect(got.app).toEqual('FOO')
-      expect((got.extensions ?? {})['test-ui-extension']).toEqual('BAR')
+      expect(got['test-ui-extension']).toEqual('BAR')
     })
   })
 })

packages/app/src/cli/models/app/identifiers.ts

@@ -34,6 +34,11 @@ export interface ExtensionUuidsByLocalIdentifier {
   [localIdentifier: string]: string
 }
 
+export interface DeployIdentifiers {
+  appModuleUuids: ExtensionUuidsByLocalIdentifier
+  appModuleRegistrationIds: ExtensionUuidsByLocalIdentifier
+}
+
 type UuidOnlyIdentifiers = Omit<Identifiers, 'extensionIds' | 'extensionsNonUuidManaged'>
 type UpdateAppIdentifiersCommand = 'dev' | 'deploy' | 'release' | 'import-extensions'
 interface UpdateAppIdentifiersOptions {
@@ -95,7 +100,7 @@ interface GetAppIdentifiersOptions {
 export function getAppIdentifiers(
   {app}: GetAppIdentifiersOptions,
   systemEnvironment = process.env,
-): Partial<UuidOnlyIdentifiers> {
+): ExtensionUuidsByLocalIdentifier {
   const envVariables = {
     ...app.dotenv?.variables,
     ...(systemEnvironment as {[variable: string]: string}),
@@ -108,8 +113,5 @@ export function getAppIdentifiers(
   }
   app.allExtensions.forEach(processExtension)
 
-  return {
-    app: envVariables[app.idEnvironmentVariableName],
-    extensions: extensionsIdentifiers,
-  }
+  return extensionsIdentifiers
 }

packages/app/src/cli/services/context.test.ts

@@ -134,7 +134,7 @@ beforeAll(async () => {
 })
 
 beforeEach(async () => {
-  vi.mocked(getAppIdentifiers).mockReturnValue({app: undefined})
+  vi.mocked(getAppIdentifiers).mockReturnValue({})
   vi.mocked(selectOrganizationPrompt).mockResolvedValue(ORG1)
   vi.mocked(selectOrCreateApp).mockResolvedValue(APP1)
   vi.mocked(selectStore).mockResolvedValue(STORE1)

packages/app/src/cli/services/context/breakdown-extensions.ts

@@ -443,7 +443,7 @@ export function configExtensionsIdentifiersReleaseBreakdown({
   return buildConfigExtensionIdentifiersBreakdown(versionConfig, activeConfig)
 }
 
-function buildConfigExtensionIdentifiersBreakdown(
+export function buildConfigExtensionIdentifiersBreakdown(
   localConfig: {[key: string]: unknown},
   remoteConfig: {[key: string]: unknown},
 ): ConfigExtensionIdentifiersBreakdown | undefined {

packages/app/src/cli/services/context/deploy-app-version-migrations.ts

@@ -0,0 +1,100 @@
+import {EnsureDeploymentIdsPresenceOptions, RemoteSource} from './identifiers.js'
+import {extensionMigrationPrompt} from './prompts.js'
+import {migrateFlowExtensions} from '../dev/migrate-flow-extension.js'
+import {migrateExtensionsToUIExtension} from '../dev/migrate-to-ui-extension.js'
+import {
+  AdminLinkModulesMap,
+  FlowModulesMap,
+  getModulesToMigrate,
+  MarketingModulesMap,
+  migrateAppModules,
+  UIModulesMap,
+} from '../dev/migrate-app-module.js'
+import {DeveloperPlatformClient} from '../../utilities/developer-platform-client.js'
+import {PartnersClient} from '../../utilities/developer-platform-client/partners-client.js'
+import {AbortSilentError} from '@shopify/cli-kit/node/error'
+
+/** Returns a fresh active app version when migrations changed remote modules. */
+export async function activeAppVersionAfterMigrations(options: EnsureDeploymentIdsPresenceOptions) {
+  const didMigrateExtensions = await migrateExtensionsIfNeeded(options)
+  return didMigrateExtensions
+    ? options.developerPlatformClient.activeAppVersion(options.remoteApp)
+    : options.activeAppVersion
+}
+
+/** Runs supported legacy extension migrations before deploy classification. */
+async function migrateExtensionsIfNeeded(options: EnsureDeploymentIdsPresenceOptions) {
+  const {app, appId, developerPlatformClient, envIdentifiers, remoteApp} = options
+  const registrations = await developerPlatformClient.appExtensionRegistrations(remoteApp, options.activeAppVersion)
+  const localExtensions = app.allExtensions
+  const identifiers = envIdentifiers
+  const remoteExtensions = registrations.app.extensionRegistrations
+  const dashboardExtensions = registrations.app.dashboardManagedExtensionRegistrations
+  const migrationClient = PartnersClient.getInstance()
+
+  let didMigrate = false
+  let migratedRemoteExtensions = remoteExtensions
+
+  const uiExtensionsToMigrate = getModulesToMigrate(
+    localExtensions,
+    migratedRemoteExtensions,
+    identifiers,
+    UIModulesMap,
+  )
+  if (uiExtensionsToMigrate.length > 0) {
+    const confirmedMigration = await extensionMigrationPrompt(uiExtensionsToMigrate)
+    if (!confirmedMigration) throw new AbortSilentError()
+    migratedRemoteExtensions = await migrateExtensionsToUIExtension({
+      extensionsToMigrate: uiExtensionsToMigrate,
+      appId,
+      remoteExtensions: migratedRemoteExtensions,
+      migrationClient,
+    })
+    didMigrate = true
+  }
+
+  const dashboardMigrations = [
+    {typesMap: FlowModulesMap, migrate: migrateFlowExtensions},
+    migrationGroup(MarketingModulesMap, 'marketing_activity'),
+    migrationGroup(AdminLinkModulesMap, 'admin_link'),
+  ]
+
+  for (const migration of dashboardMigrations) {
+    const extensionsToMigrate = getModulesToMigrate(
+      localExtensions,
+      dashboardExtensions,
+      identifiers,
+      migration.typesMap,
+    )
+    if (extensionsToMigrate.length === 0) continue
+
+    // eslint-disable-next-line no-await-in-loop
+    const confirmedMigration = await extensionMigrationPrompt(extensionsToMigrate, false)
+    if (!confirmedMigration) throw new AbortSilentError()
+
+    // eslint-disable-next-line no-await-in-loop
+    const newRemoteExtensions = await migration.migrate({
+      extensionsToMigrate,
+      appId,
+      remoteExtensions: dashboardExtensions,
+      migrationClient,
+    })
+    migratedRemoteExtensions = migratedRemoteExtensions.concat(newRemoteExtensions)
+    didMigrate = true
+  }
+
+  return didMigrate
+}
+
+/** Adapts app-module migrations to the shared dashboard migration loop. */
+function migrationGroup(typesMap: {[key: string]: string[]}, type: string) {
+  return {
+    typesMap,
+    migrate: (options: {
+      extensionsToMigrate: Parameters<typeof migrateAppModules>[0]['extensionsToMigrate']
+      appId: string
+      remoteExtensions: RemoteSource[]
+      migrationClient: DeveloperPlatformClient
+    }) => migrateAppModules({...options, type}),
+  }
+}