Skip to content

[Tests] Add unit tests for hrtime utilities#8051

Open
gonzaloriestra wants to merge 4 commits into
mainfrom
tests-hrtime-utils-11795562735304887944
Open

[Tests] Add unit tests for hrtime utilities#8051
gonzaloriestra wants to merge 4 commits into
mainfrom
tests-hrtime-utils-11795562735304887944

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The hrtime utility in @shopify/cli-kit was lacking unit tests.

WHAT is this pull request doing?

Introduces unit tests for startHRTime and endHRTimeInMs in packages/cli-kit/src/public/node/hrtime.test.ts.

How to test your changes?

CI

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 11795562735304887944 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 10, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label Jul 10, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review July 10, 2026 08:43
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner July 10, 2026 08:43
@gonzaloriestra
gonzaloriestra force-pushed the tests-hrtime-utils-11795562735304887944 branch from 31030f8 to 5413882 Compare July 16, 2026 08:17
@gonzaloriestra
gonzaloriestra force-pushed the tests-hrtime-utils-11795562735304887944 branch from 5413882 to 6d9ff79 Compare July 16, 2026 08:17
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner July 16, 2026 08:51
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release.

🏳️ Removed Flags

The following flags were removed from existing commands:

Command Flag
app:dev --install-mkcert
app:dev --store-password
theme:dev --reconciliation-strategy

🔧 Removed Environment Variables

The following env vars are no longer referenced in command flags:

Env Var Previously Used By
SHOPIFY_FLAG_INSTALL_MKCERT app:dev --install-mkcert
SHOPIFY_FLAG_STORE_COUNTRY store:create:preview --country
SHOPIFY_FLAG_RECONCILIATION_STRATEGY theme:dev --reconciliation-strategy

@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/object.d.ts
@@ -38,14 +38,6 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
  * @returns True if the objects are equal, false otherwise.
  */
 export declare function deepCompare(one: object, two: object): boolean;
-/**
- * Deeply compares two values and treats arrays as order-insensitive.
- *
- * @param one - The first value to be compared.
- * @param two - The second value to be compared.
- * @returns True if the normalized values are equal, false otherwise.
- */
-export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
 /**
  * Return the difference between two nested objects.
  *
packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.5.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.4.0";
\ No newline at end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant