[Tests] Add unit tests for hrtime utilities#8051
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
31030f8 to
5413882
Compare
5413882 to
6d9ff79
Compare
|
| Command | Flag |
|---|---|
app:dev |
--install-mkcert |
app:dev |
--store-password |
theme:dev |
--reconciliation-strategy |
🔧 Removed Environment Variables
The following env vars are no longer referenced in command flags:
| Env Var | Previously Used By |
|---|---|
SHOPIFY_FLAG_INSTALL_MKCERT |
app:dev --install-mkcert |
SHOPIFY_FLAG_STORE_COUNTRY |
store:create:preview --country |
SHOPIFY_FLAG_RECONCILIATION_STRATEGY |
theme:dev --reconciliation-strategy |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/object.d.ts@@ -38,14 +38,6 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
* @returns True if the objects are equal, false otherwise.
*/
export declare function deepCompare(one: object, two: object): boolean;
-/**
- * Deeply compares two values and treats arrays as order-insensitive.
- *
- * @param one - The first value to be compared.
- * @param two - The second value to be compared.
- * @returns True if the normalized values are equal, false otherwise.
- */
-export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
/**
* Return the difference between two nested objects.
*
packages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.5.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.4.0";
\ No newline at end of file
|
WHY are these changes introduced?
The
hrtimeutility in@shopify/cli-kitwas lacking unit tests.WHAT is this pull request doing?
Introduces unit tests for
startHRTimeandendHRTimeInMsinpackages/cli-kit/src/public/node/hrtime.test.ts.How to test your changes?
CI
Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 11795562735304887944 started by @gonzaloriestra