Skip to content

[Security] Upgrade hashing to SHA-256#7682

Draft
gonzaloriestra wants to merge 2 commits into
mainfrom
security-upgrade-hashing-sha256-811138014799838999
Draft

[Security] Upgrade hashing to SHA-256#7682
gonzaloriestra wants to merge 2 commits into
mainfrom
security-upgrade-hashing-sha256-811138014799838999

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

SHA-1 is considered a weak cryptographic hash and should be replaced with a stronger algorithm like SHA-256, especially when handling sensitive data or generating identifiers.

WHAT is this pull request doing?

  • Upgrades hashString to use SHA-256.
  • Upgrades nonRandomUUID to use SHA-256 while maintaining the 36-character UUID format by truncating the hash.
  • Updates relevant unit tests in cli-kit that were affected by the change in hash algorithm and generated values.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 811138014799838999 started by @gonzaloriestra

Replaces SHA-1 with SHA-256 in hashString and nonRandomUUID to resolve security vulnerabilities related to weak cryptography.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 31, 2026
Replaces SHA-1 with SHA-256 in hashString and nonRandomUUID to resolve security vulnerabilities related to weak cryptography.
Updates unit tests to reflect the new hash algorithm and resulting values.
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/crypto.d.ts
@@ -20,10 +20,10 @@ export declare function base64URLEncode(str: Buffer): string;
  */
 export declare function sha256(str: string): Buffer;
 /**
- * Generate the SHA1 hash of a string.
+ * Generate the SHA256 hash of a string.
  *
  * @param str - The string to hash.
- * @returns The SHA1 hash of the string.
+ * @returns The SHA256 hash of the string.
  */
 export declare function hashString(str: string): string;
 /**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant