[Security] Upgrade hashing to SHA-256#7682
Conversation
Replaces SHA-1 with SHA-256 in hashString and nonRandomUUID to resolve security vulnerabilities related to weak cryptography.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaces SHA-1 with SHA-256 in hashString and nonRandomUUID to resolve security vulnerabilities related to weak cryptography. Updates unit tests to reflect the new hash algorithm and resulting values.
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/crypto.d.ts@@ -20,10 +20,10 @@ export declare function base64URLEncode(str: Buffer): string;
*/
export declare function sha256(str: string): Buffer;
/**
- * Generate the SHA1 hash of a string.
+ * Generate the SHA256 hash of a string.
*
* @param str - The string to hash.
- * @returns The SHA1 hash of the string.
+ * @returns The SHA256 hash of the string.
*/
export declare function hashString(str: string): string;
/**
|
WHY are these changes introduced?
SHA-1 is considered a weak cryptographic hash and should be replaced with a stronger algorithm like SHA-256, especially when handling sensitive data or generating identifiers.
WHAT is this pull request doing?
hashStringto use SHA-256.nonRandomUUIDto use SHA-256 while maintaining the 36-character UUID format by truncating the hash.cli-kitthat were affected by the change in hash algorithm and generated values.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 811138014799838999 started by @gonzaloriestra