ci: run the pipeline on pull requests only - #191
Merged
Conversation
Every change went through CI twice: once as a pull request, then again as the
merge commit landing on main. The second run tests the tree the first one
already covered — roughly 35 job-minutes per change, with both runs drawing on
the same runner pool.
Drop the `push: [main, master]` trigger. The paths a pull request does not
cover are handled elsewhere:
- Direct pushes to main (release cuts) get `workflow_dispatch` for an
on-demand run, and the nightly task already runs all four suites against
main every day at 22:00.
- CodeQL keeps its own `push: [main]` trigger. Only a run on the default
branch updates the code-scanning dashboard, so that duplication is load
bearing and stays.
The README badge is pinned to `?event=pull_request`: without runs on the
default branch an unqualified badge has nothing to report. While there, the
pipeline description was three jobs and a 45 % coverage gate — it is five jobs
and 85 % line / 70 % branch since 2026-07-27.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every change went through CI twice: once as a pull request, then again as the merge commit landing on
main. The second run tests the tree the first one already covered — roughly 35 job-minutes per change, with both runs drawing on the same runner pool.This drops the
push: [main, master]trigger fromci.yml. The paths a pull request does not cover are handled elsewhere:main(release cuts) getworkflow_dispatchfor an on-demand run, and the nightly task already runs all four suites againstmainevery day at 22:00.push: [main]trigger. Only a run on the default branch updates the code-scanning dashboard, so that duplication is load bearing and stays.The README badge is pinned to
?event=pull_request: without runs on the default branch, an unqualified badge has nothing to report.While in that paragraph, two stale numbers: the pipeline description said three jobs and a 45 % coverage gate — it has been five jobs and 85 % line / 70 % branch since 2026-07-27.