fix: serialize CompleteMultipartUpload across HA pods - #148
Merged
Conversation
Concurrent complete requests for the same upload_id on different pods caused duplicate upstream CompleteMultipartUpload calls and NoSuchUpload failures on large Scylla backup uploads. Add a Redis/memory per-upload lock, idempotent complete when metadata and object already exist, and unit tests for serialization and peer-finished paths. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompleteUploadLock(Redis or in-memory) so only one pod can finalize a multipart upload at a time.handle_complete_multipart_uploadin the lock to prevent concurrent upstreamCompleteMultipartUploadraces.Fixes prod incident where Scylla backup uploads failed with
NoSuchUploadafter s3proxy pods raced on complete during a rollout.Test plan
tests/unit/test_complete_upload_lock.py— concurrent complete serialization, idempotent peer-finished path, lock timeoutMade with Cursor