ci: remove redundant, broken release.yml publish workflow - #28
Merged
Conversation
release.yml fired on tag push and tried to publish to PyPI without the trusted publisher config used by python-publish.yml, so it failed on every release. Its Create GitHub Release step ran after the failing upload in the same job, so a tag push produced no release either. Dropping only the upload step would be worse: a release created by a workflow using GITHUB_TOKEN does not raise release: published, so python-publish.yml would not start and the tag would yield a release with nothing on PyPI. Every release in this repo was published by a user creating the GitHub release with python-publish.yml picking up the event, all user-authored with no attached assets, so release.yml never produced one. That path is unchanged. CONTRIBUTING.md now documents it, including why the release must be created by a user. Matches the same cleanup in upmex and src2purl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release.ymltriggered on av*tag push, built the package, then uploaded it withpypa/gh-action-pypi-publishand noenvironment:. The PyPI trusted publisher for this project is configured forpython-publish.ymlwith thepypienvironment, so the claims sent byrelease.ymlcould never match and it failed withinvalid-publisheron every release.The failure had a second effect:
Create GitHub Releasewas a later step in the same job, so a tag push produced no GitHub release either.Why remove it rather than fix the upload
Dropping only the upload step and keeping the release creation would be worse than the current state. A release created by a workflow using
GITHUB_TOKENdoes not raise therelease: publishedevent, sopython-publish.ymlwould not start. A tag push would then produce a GitHub release with nothing published to PyPI, failing silently instead of visibly.Making the upload work from
release.ymlwould require a second trusted publisher entry on PyPI for that workflow, duplicating configuration for a path already covered.Verified before changing anything: every release in this repo is user-authored, none by
github-actions[bot], and all have zero attached assets, sorelease.ymlnever created one. Everypython-publish.ymlrun succeeded; everyrelease.ymlrun failed. The working path is untouched here.Changes
.github/workflows/release.yml.CONTRIBUTING.md, which had no release section: version bump, tag,gh release create --generate-notes. Notes why step 3 must be a user action, and that uploads should be confirmed against the version-specific PyPI endpoint since the aggregate one is cached and lags.python-publish.ymland the remaining workflows are untouched, and nothing referencedrelease.yml.This matches the same cleanup already merged in
upmex(#89) andsrc2purl(#57).