hir_analysis: collect CoroutineClosure in OpaqueTypeCollector#577
Open
SebTardif wants to merge 1 commit into
Open
hir_analysis: collect CoroutineClosure in OpaqueTypeCollector#577SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Async closures can embed opaque types in their signatures and upvars. Walk CoroutineClosure like Closure/Coroutine so nested opaques are found. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpaqueTypeCollectorincheck.rswalksClosureandCoroutineto record theirdef_ids and recurse, but missedCoroutineClosure. Async closures can embed nested opaques in signatures/upvars; include them in the visitor.Closes #483
Origin
Collector arm dates from the Generator/Coroutine rename era:
rust-lang@6095683
CoroutineClosureadded later:rust-lang@c567edd
Test plan
fix-opaque-type-collector-coroutine-closurefix (e2614fc)