ci: avoid redundant dashboard builds#74
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
tracedecay/.github/workflows/ci.yml
Lines 55 to 56 in dbc9df2
In these Rust jobs, a fresh checkout still reaches build.rs when cargo test/cargo clippy/cargo build starts; the dashboard JS/CSS dist files are gitignored, and build.rs detects them as missing then runs npm ci and npm run build (build.rs:263-273, build.rs:125-134). Because this change removed actions/setup-node from those jobs without sharing the Dashboard job’s generated dist artifacts across job workspaces, they now rebuild the dashboard using whatever npm happens to be on the runner PATH, losing the pinned Node 22 setup/cache and making the CI path slower and less deterministic rather than avoiding redundant builds.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Validation