backend tensor#106
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 73.53% 73.61% +0.08%
==========================================
Files 91 91
Lines 20508 20800 +292
==========================================
+ Hits 15080 15312 +232
- Misses 5428 5488 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
| coverage run -p -m act.pipeline --verify vnnlib --category acasxu_2023 --max-instances 2 \ | ||
| --solvers dual --bab --bab-solver-tier dual_alpha_eta \ | ||
| --bab-bounding-method topk --bab-branching-method babsr \ | ||
| --bab-bounding depth_lb --bab-branching-method babsr \ |
There was a problem hiding this comment.
What does depth_lb mean here? Could you make the name easier to understand and add a comment to where it is defined (e.g., in the config.yaml and cli.py)
| # by a swappable order strategy; supports frontier-cap eviction (``evict_to``), | ||
| # which drops worst-priority leaves and forces a sound ``UNKNOWN``. | ||
| # * ``MCTSBounding`` — MCTS side tables (``N``/``Q``) over the BaB tree, maintained as | ||
| # a pure observer; ``pop`` is plain top-k until UCB1 selection lands. |
There was a problem hiding this comment.
Fix these comments to reflect the below bounding strategies using a table with explanations, and better to rename depth_lb, sa and diverse.
"random",
"depth_lb",
"greedy",
"sa",
"diverse",
"mcts",
There was a problem hiding this comment.
Also fix the top-k and make sure it works as a parameter and only for the first three options.
2 participants
Uh oh!
There was an error while loading. Please reload this page.