-
Notifications
You must be signed in to change notification settings - Fork 569
Range for loop for statements #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alvov1
wants to merge
8
commits into
SRombauts:master
Choose a base branch
from
Alvov1:181-feature-statement-iterator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d42e665
Implement testing for range-based for statement loop
Alvov1 b51ba20
Implement RowIterator class
Alvov1 f889053
Implement test to validate row iterator traits
Alvov1 bcd2db8
Add traits to RowIterator
Alvov1 83bb827
Update changelog
Alvov1 1a9abc8
Remove explicit copy constructor from RowIterator
Alvov1 e7d12d9
Restore blank lines removed by accident
Alvov1 c996909
Implement equality and postfix increment operators
Alvov1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description calls this "full iterator traits." The traits are all here, but the interface isn't: there's no
operator==and no post-incrementoperator++(int)next to thisoperator!=. Range-based for only callsoperator!=, so nothing breaks today. The catch is that anyone who reaches for it with<algorithm>, or checks it against the C++20std::input_iteratorconcept (which requires==), hits a wall. Either addoperator==and post-increment, or soften the claim to "usable in range-based for loops."