fix(format): preserve model column dialect - #5926
Open
fresioAS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Andreas Fredhøi <andreas.fredhoi@fresio.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
columnsschema using the model's dialect.DATETIME2(6)for T-SQL and Fabric.Context
MODEL headers were recently changed to use SQLGlot's generic generator so that
T-SQL would not rewrite SQLMesh boolean properties such as
FALSEinto(1 = 0).However, the
columnsproperty contains dialect-specific data types. Renderingit with the generic generator changed
DATETIME2(6)intoTIMESTAMP(6)forT-SQL and Fabric models.
This change keeps the generic header behavior while rendering only the
columnsschema with the model dialect.Test Plan
tsqlandfabric.FALSE.tests/core/test_dialect.pysuite passes: 161 tests.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO