Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlmesh/core/engine_adapter/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ def with_settings(self, **kwargs: t.Any) -> EngineAdapter:
"query_execution_tracker": kwargs.pop(
"query_execution_tracker", self._query_execution_tracker
),
"pre_ping": kwargs.pop("pre_ping", self._pre_ping),
**self._extra_config,
**kwargs,
}
Expand Down
9 changes: 9 additions & 0 deletions tests/core/engine_adapter/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -3522,6 +3522,15 @@ def test_pre_ping(mocker: MockerFixture, make_mocked_engine_adapter: t.Callable)
adapter._connection_pool.get().close.assert_called_once()


def test_with_settings_preserves_pre_ping(make_mocked_engine_adapter: t.Callable):
adapter = make_mocked_engine_adapter(EngineAdapter, pre_ping=True)
assert adapter.with_settings()._pre_ping is True
assert adapter.with_settings(pre_ping=False)._pre_ping is False

adapter = make_mocked_engine_adapter(EngineAdapter)
assert adapter.with_settings()._pre_ping is False


@pytest.mark.parametrize(
"partitioned_by",
[
Expand Down
Loading