Skip to content

Removed a redundant line that fails the test#5819

Merged
StuffbyYuki merged 1 commit into
mainfrom
yuki/ci-bug
May 31, 2026
Merged

Removed a redundant line that fails the test#5819
StuffbyYuki merged 1 commit into
mainfrom
yuki/ci-bug

Conversation

@StuffbyYuki
Copy link
Copy Markdown
Collaborator

Description

A CI style test has been failing.

Cause

  • CI runs mypy on Python 3.11+ (your log shows .venv on 3.13). For those versions, the lockfile resolves pandas-stubs 3.x (3.0.3.260530), which matches pandas 3.0 typing and no longer declares check_datetimelike_compat on assert_frame_equal. The runtime dependency is still pandas<3.0.0, but the call in definition.py uses a kwarg that the newer stubs dropped:

Solution

  • The safest one-line fix is to drop check_datetimelike_compat=True. It’s redundant here: just before assert_frame_equal, the code already normalizes datetime-like values via _to_hashable, which converts them to strings:

Test

  • Ran make style locally and passed

Test Plan

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

Signed-off-by: stuffbyyuki <kake.19940627@gmail.com>
@StuffbyYuki StuffbyYuki merged commit ee960d1 into main May 31, 2026
31 checks passed
@StuffbyYuki StuffbyYuki deleted the yuki/ci-bug branch May 31, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants