Expose 'Linear' row alignment in the GUI#42
Merged
Conversation
The backend align_rows supports median, mean, and linear (linear also removes a straight slope within each row), and the Definitions help documents all three — but the GUI's "Align rows" dropdown only offered None/Median/Mean, so the documented 'linear' option was unreachable. Add "Linear" to the Align rows control (probeflow/gui/processing.py: combo items, state align_map, set_state reverse map, tooltip) and to the menu-bar mirror (probeflow/gui/dialogs/image_viewer_chrome_mixin.py). The state→op pipeline already passes the method through generically, so linear works end to end. Test: test_align_rows_exposes_linear_option. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Definitions help documents three row-alignment methods (median / mean / linear), and the backend
align_rowssupports all three — but the GUI's Align rows dropdown only offered None/Median/Mean, so the documentedlinearoption was unreachable (reported from the doc-vs-UI mismatch).Adds Linear to:
state/set_stateindex maps, and tooltip (probeflow/gui/processing.py)probeflow/gui/dialogs/image_viewer_chrome_mixin.py)The state→op pipeline already passes
methodthrough generically (gui_adapter→align_rows(method=...)), so linear works end to end with no backend change.Verification
[None, Median, Mean, Linear],set_state({'align_rows':'linear'})selects it,state()returnslinear, andapply_processing_stateruns it.test_align_rows_exposes_linear_option;test_gui_processing_panel+test_viewer_window_menugreen;ruffclean.🤖 Generated with Claude Code