Merge ROI + Masks sidebar tabs; reorder to View/Process/Measure/ROI-Mask/Export#39
Merged
Merged
Conversation
The image viewer had 6 sidebar tabs (View, Process, ROI, Masks, Measure,
Export); the labels truncated ("Proc...", "Ma...", "Mea...") and the ROI/Masks
tabs were mostly empty forms. Combine them and reorder so labels fit.
- ROI and Masks now share a single "ROI/Mask" tab, each as a collapsible
section (reusing _collapsible_section, the same widget as the View tab's
"Spectroscopy overlay"). "Regions of interest" is expanded by default; "Masks"
starts collapsed. See the _sidebar_tab + panel wiring in
probeflow/gui/dialogs/image_viewer_build_mixin.py.
- Tab order is now View, Process, Measure, ROI/Mask, Export.
- The old "masks" tab key is aliased to the merged tab's index (no extra rail
entry); _show_sidebar_tab("masks") selects the tab and expands the Masks
section via self._mask_section_btn (image_viewer_chrome_mixin.py), so any
future mask-driven navigation still reveals the controls.
- Keyboard shortcuts renumbered to match the new on-screen order: Ctrl+1 View,
Ctrl+2 Process, Ctrl+3 Measure, Ctrl+4 ROI/Mask, Ctrl+5 Export
(probeflow/gui/viewer/shortcuts.py); the command->tab lambdas are unchanged.
Test: test_sidebar_merges_roi_mask_and_orders_tabs.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
QoL cleanup of the image-viewer sidebar. The 6 tabs (View, Process, ROI, Masks, Measure, Export) truncated their labels, and ROI/Masks were mostly empty forms.
_collapsible_section, the same widget as View's "Spectroscopy overlay"). "Regions of interest" expanded by default; "Masks" collapsed."masks"tab key aliased to the merged tab;_show_sidebar_tab("masks")selects it and expands the Masks section (future-proofs mask-driven navigation).Why it's low risk
Nothing programmatically opened the Masks tab; no test asserted sidebar order/labels. The merge reuses existing panels/helpers — only wiring and order change.
Tests
New
test_sidebar_merges_roi_mask_and_orders_tabs; viewer/shortcut GUI suites green (test_gui_processing_panel,test_viewer_shortcuts,test_viewer_window_menu, region/levels/lifecycle),ruffclean.🤖 Generated with Claude Code