REPL.4: default install = self-contained -all bundle (installer rework + bundle provenance disclosure) - #167
Draft
fupelaqu wants to merge 1 commit into
Draft
REPL.4: default install = self-contained -all bundle (installer rework + bundle provenance disclosure)#167fupelaqu wants to merge 1 commit into
fupelaqu wants to merge 1 commit into
Conversation
…e; bundle provenance disclosure Story REPL.4 (epic REPL Hardening) — elasticsql side of the -all bundle design (the bundles themselves are built by the private softclient4es-repl BOM repo): - install.sh: dual artifact names (plain cli / cli-all); version listing and latest-resolution follow the artifact actually downloaded (the -all bundle has its own version line); bundle-selection block sets USE_BUNDLE with graceful fallback to the plain artifact + coursier extensions path (no bundle published, engine-only -v, Java < 11, unreachable artifact via probe_url); bundled installs skip dependency resolution entirely; AC-4b licence notice on every path (bundle = Apache-2.0 engine + ELv2 extensions + proprietary JOIN engine, free to use — never labeled open source); bundle-aware VERSION file, summary and help; legacy pre-0.20 community 0.1.x path untouched - set -e hardening: empty bundle listings (grep -v on no lines) no longer abort the installer — they fall back as designed - core: new BundleInfo reads softclient4es-bundle-info.properties from the classpath (stamped by the -all bundles); welcome banner discloses bundle provenance via a fixed-width formatLigne line; new 'version' meta-command in both dispatchers prints engine + bundle/extension versions; 8 unit tests (resource injected via test ClassLoader) - documentation/client/repl.md: dual-artifact, combined-licence, bundle version line and issue-tracker front-door sections - version bump 0.20.1 -> 0.20.2-SNAPSHOT (shared REPL.x line; the same-line bump in sibling REPL PRs is an expected trivial conflict) Refs #163 (fix 4: -all bundle installer) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story REPL.4 (epic REPL Hardening) — elasticsql side
The
-allbundles themselves are built by the privatesoftclient4es-replBOM/packaging repo (companion PR there). This PR reworks the installer and adds the core provenance-disclosure surface.install.sh
softclient4es{N}-cli(pure Apache-2.0) vssoftclient4es{N}-cli-all(self-contained bundle, its OWN version line)--list-versions/ latest-resolution follow the artifact actually downloaded (bundle listing by default, plain under--no-extensions/fallbacks)USE_BUNDLE; graceful fallbacks (no bundle published, engine-only-v, Java < 11,probe_urlmiss) → plain artifact + coursier extensions path, byte-identical legacy behavior incl. pre-0.20 community 0.1.x ruleset -ehardening: empty listings no longer abort the installer (review finding, patched + live-tested)core (Repl)
BundleInfo: readssoftclient4es-bundle-info.properties(stamped by-allbundles); property-key contract shared with the bundle build + BundleMain shimformatLigneline); newversionmeta-command in both dispatchers; 8 unit testsdocs
documentation/client/repl.md: dual-artifact + combined-licence + bundle-version-line + issue-tracker front door (MDX mirror to softclient4es-web = PD-5 companion follow-up, not a merge blocker)Notes
+ core/compile(2.12+2.13), scalafmt,bash -n, live installer smokes (bundle-absent fallback, simulated-bundle dry-runs)Refs #163 (fix 4: -all bundle installer)
🤖 Generated with Claude Code
Part of epic #169 (REPL Hardening). Discovered during the bundle E2E smoke: #168 (es6 client closure excludes all log4j — plain es6 cli 0.20.1 broken; fix to ride 0.20.2).