Migrate Public Data Sharing settings page to Angular

[nllong]

Summary

Ports the legacy AngularJS Organization Sharing page (/accounts/:organization_id/sharing) to this app under organizations/settings/sharing, per MIGRATION.md.

• New SharingComponent: public feed status banner (link to Options to enable/disable), collapsible URL/query-param docs (JSON/HTML, GeoJSON when enabled), a working Public Query Threshold field (the legacy page fetched this value but never actually rendered a control for it), a searchable/filterable public column-selection table with select-all/indeterminate state, owner + is_parent permission gating (reuses UserService.auth$), loading/error/success states, save -> reload, dark mode, and responsive layout.
• Reuses existing /api/v3/ endpoints only -- no backend changes:
  • OrganizationService.getSharedFields() -> organizations/{id}/shared_fields/
  • OrganizationService.getQueryThreshold() -> organizations/{id}/query_threshold/
  • AnalysisService.getUsedColumns() -> analyses/used_columns/
  • Save reuses the existing OrganizationService.updateSettings() -> organizations/{id}/save_settings/
• Route + nav entry added under Organization Settings.
• Added the ~12 Transloco keys that were missing (reused ~30 existing legacy strings for the rest).
• Updated MIGRATION.md and .github/copilot-instructions.md status lists.

Screenshots

Overall page (public feed enabled, query threshold set, fields populated from seeded data):

Field search/filter + select-all (indeterminate state) interaction:

Validation

• pnpm lint and pnpm build pass.
• Live-tested end-to-end against a throwaway Docker backend with seeded property/tax lot data via Playwright: save/reload round-trip, field search + select-all, query-threshold validation, non-owner permission block, dark mode, and mobile layout.

Files touched

• src/app/modules/organizations/settings/sharing/sharing.component.ts and .html (new)
• src/app/modules/organizations/settings/settings.routes.ts and settings.component.ts
• src/@seed/api/organization/organization.service.ts and organization.types.ts
• src/@seed/api/analysis/analysis.service.ts and analysis.types.ts
• public/i18n/en_US.json
• MIGRATION.md, .github/copilot-instructions.md

Remaining risks

• New Transloco keys were added to en_US.json for local dev but still need to be registered in Lokalise (source of truth) before the next pnpm update-translations pull, or they'll be overwritten.
• Legacy AngularJS organization_sharing route/controller/partial were left untouched, per migration convention.

Update: "Add a field" + public URL test buttons

Follow-up based on review feedback that it wasn't clear how to add a new column to the public
list, and that testing the public feed URLs required manual copy/paste.

• Add a field: the table previously only listed columns already populated with data
  (analyses/used_columns/). Added an "Add a field" autocomplete (backed by the existing
  ColumnService.getPropertyColumns() -> /api/v3/columns/ endpoint, same one used by the Column
  Settings page) that lists every Property/Tax Lot column in the org and appends the picked one as
  a new (unchecked) row -- so a field without data yet can still be marked public and saved.
• Also fixed a latent edge case while touching this: a column already marked public that later
  lost all its data would silently fall out of used_columns and get unshared on the next save;
  it's now kept in the list instead.
• Test buttons: added icon buttons next to the public JSON and HTML feed URLs that open them
  in a new tab. Discovered along the way that a plain <a target="_blank"> to these (same-origin)
  URLs was being silently downgraded back to same-tab navigation by the app-wide
  ExternalLinkDirective (it only forces a new tab for cross-origin links) -- worked around with
  an explicit window.open() call instead.
• Clarified the in-template comments/help text and PUBLIC_SHARE_FIELDS_HELP copy to explain how
  the row list is populated and how to add to it.
• New Transloco keys added to en_US.json.

Screenshots

Updated page with the "Add a field" control and public-URL "Test" buttons:

Typing in "Add a field" filters the org's full column catalog (not just used ones):

"Test" buttons next to the public JSON/HTML feed URLs:

Validation

• pnpm lint and pnpm build pass.
• Live-tested against this environment's real backend/data via Playwright: added an unused column
  via the new autocomplete, checked it and confirmed it lands in the save payload; clicked both
  "Test" buttons and confirmed each opens a distinct new tab with real feed data (no console
  errors, verified via browser_tabs/browser_console_messages).

[Copilot]

Pull request overview

Ports the legacy Organization Sharing settings page into the Angular app under organizations/settings/sharing, including public feed URL documentation, query-threshold configuration, and a field-sharing selection UI backed by existing /api/v3/ endpoints.

Changes:

• Added a new Organization Sharing settings route + navigation entry under Organization Settings.
• Implemented a new Sharing settings UI (public feed status, URL docs/test buttons, query threshold form, sharable-fields table + “Add a field” autocomplete).
• Extended API layer types/services to fetch shared fields, query threshold, and “used columns” for the sharing UI.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/app/modules/organizations/settings/sharing/sharing.component.ts	New Sharing page component: loads sharing data, handles filtering/selection, saves org settings.
src/app/modules/organizations/settings/sharing/sharing.component.html	New Sharing page template: public feed status/docs, query threshold input, add-field autocomplete, share table + actions.
src/app/modules/organizations/settings/settings.routes.ts	Adds the /organizations/settings/sharing route.
src/app/modules/organizations/settings/settings.component.ts	Adds the Sharing entry to the settings navigation list.
src/@seed/api/organization/organization.types.ts	Adds query_threshold/public_fields to Organization and defines shared-fields + query-threshold response types.
src/@seed/api/organization/organization.service.ts	Adds getSharedFields() and getQueryThreshold() API methods.
src/@seed/api/analysis/analysis.types.ts	Adds UsedColumn/UsedColumnsResponse types for the used-columns endpoint.
src/@seed/api/analysis/analysis.service.ts	Adds getUsedColumns() API method for the sharing UI.
public/i18n/en_US.json	Adds new Transloco keys used by the Sharing page UI.
MIGRATION.md	Marks Organization Sharing as migrated and updates the route mapping notes.
.github/copilot-instructions.md	Updates the migration status snapshot to include Organization Sharing.

Suppressed comments (2)

src/app/modules/organizations/settings/sharing/sharing.component.html:200

• Each per-row mat-checkbox has no accessible label, so assistive tech can’t tell which field is being shared. Add an aria-label that includes the field’s display name.

                          <mat-checkbox [(ngModel)]="field.public_checked" [ngModelOptions]="{ standalone: true }"></mat-checkbox>

src/app/modules/organizations/settings/sharing/sharing.component.html:95

• This heading is user-visible but isn’t passed through Transloco on a newly migrated page. Wrap it with t(...) so it can be localized consistently.

                    <h3>GeoJSON</h3>