Skip to content

fix(agentgateway): address Nicole review feedback on PR #220 #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiagoek merged 1 commit into from
Jul 17, 2026
Merged

fix(agentgateway): address Nicole review feedback on PR #220 #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sap_cloud_sdk/agentgateway/agw_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
)
from sap_cloud_sdk.agentgateway._token_cache import _GatewayUrlCache, _TokenCache
from sap_cloud_sdk.agentgateway.exceptions import AgentGatewaySDKError
from sap_cloud_sdk.core._telemetry_compat import Module, Operation, record_metrics
from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics

logger = logging.getLogger(__name__)

Expand Down
31 changes: 0 additions & 31 deletions src/sap_cloud_sdk/core/_telemetry_compat.py
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/sap_cloud_sdk/destination/certificate_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from typing import List, Optional, TypeVar, Callable

from sap_cloud_sdk.core._telemetry_compat import Module, Operation, record_metrics
from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics
from sap_cloud_sdk.destination._http import DestinationHttp, API_V1
from sap_cloud_sdk.destination._models import (
AccessStrategy,
Expand Down
4 changes: 1 addition & 3 deletions src/sap_cloud_sdk/destination/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
import warnings
from typing import Any, Dict, List, Optional, Callable, TypeVar

# Conditional telemetry import - works even when telemetry packages are not installed
from sap_cloud_sdk.core._telemetry_compat import Module, Operation, record_metrics

from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics
from sap_cloud_sdk.core.secret_resolver import read_from_mount_and_fallback_to_env_var
from sap_cloud_sdk.destination._http import DestinationHttp, API_V1, API_V2
from sap_cloud_sdk.destination._models import (
Expand Down
2 changes: 1 addition & 1 deletion src/sap_cloud_sdk/destination/fragment_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from typing import Callable, List, Optional, TypeVar

from sap_cloud_sdk.core._telemetry_compat import Module, Operation, record_metrics
from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics
from sap_cloud_sdk.destination._http import DestinationHttp, API_V1
from sap_cloud_sdk.destination._models import (
AccessStrategy,
Expand Down
4 changes: 2 additions & 2 deletions tests/agentgateway/unit/test_lob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
from sap_cloud_sdk.agentgateway._models import Agent, AgentCard, MCPTool
from sap_cloud_sdk.agentgateway._token_cache import _GatewayUrlCache, _TokenCache
from sap_cloud_sdk.agentgateway.config import ClientConfig
from sap_cloud_sdk.destination import ConsumptionOptions, ConsumptionLevel
from sap_cloud_sdk.agentgateway.exceptions import AgentGatewaySDKError, MCPServerNotFoundError
from sap_cloud_sdk.destination import ConsumptionLevel, ConsumptionOptions
from sap_cloud_sdk.destination import ConsumptionLevel

# Aliases for use in existing test assertions
_LABEL_KEY = LABEL_KEY
Expand Down Expand Up @@ -1065,4 +1066,3 @@ def test_raises_when_landscape_env_not_set(self):
with patch("sap_cloud_sdk.agentgateway._lob._ias_dest_name", side_effect=EnvironmentError("APPFND_CONHOS_LANDSCAPE not set")):
with pytest.raises(EnvironmentError, match="APPFND_CONHOS_LANDSCAPE"):
get_ias_client_id_lob()

Loading