Conversation
|
matt take a look at this |
ncorrea210
self-requested a review
July 16, 2026 01:48
ncorrea210
self-requested a review
July 16, 2026 01:49
ncorrea210
approved these changes
Jul 16, 2026
Author
|
LGTM |
Also change initialization of drivers
|
Add .gitignore for build folder. Delete eclipse folders (and do .gitignore for those) |
|
Debug folder can be deleted, not needed anymore |
CDC communication is to add commands like READ_FILE to read from the lfs file. Timer shuts down the flash after an hour. Also increase stack size (just in case).
Author
|
What do you mean fake 😭 as in not real. Also why can I update your comment? |
|
@wispl what is timer three being used for? It doesn't seem to be used for anything, can we disable it? |
ncorrea210
requested review from
dmanslick
and removed request for
Schmiff1 and
shivammpat
July 19, 2026 00:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of things rolled into one,