Win32: Introduce safe wrapper for window creation process and lifecycle#259
Merged
Conversation
prokopyl
changed the title
prokopyl
force-pushed
the
hwnd_wrapper
branch
2 times, most recently
from
3a2fe37 to
4d80b11
Compare
micahrj
reviewed
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an internal safe wrapper (
WindowImpl) around the Win32 window creation process and lifecycle.This also makes it possible to properly handle messages sent to the Baseview window while processing the
WM_CREATEandWM_DESTROYmessages. It also makes it possible to safely send, receive and processWM_DESTROYmessages during any event handler.This means the Baseview implementation (or user implementation) can now perform non-trivial work during window creation, and any generated messages (e.g. window resizing) will not be missed by Baseview's internal handlers.
This PR also moves the initialization process from after
CreateWindowis called to during the processing of theWM_CREATEmessage.