Skip to content

[Improve] Sharpen Triage GitHub Issues plan and clarification comments#569

Merged
mrubens merged 2 commits into
developfrom
feature/triage-github-issues-prompt-format-30eaplnoe77tu
Jul 18, 2026
Merged

[Improve] Sharpen Triage GitHub Issues plan and clarification comments#569
mrubens merged 2 commits into
developfrom
feature/triage-github-issues-prompt-format-30eaplnoe77tu

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Discord.

Related issue

N/A — follow-up polish after #557.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Updated Triage GitHub Issues comment templates:

  • Clearer clarifying-question and proposed-plan shapes
  • Less exact gh CLI ceremony
  • Mentions use the deployment-configured GitHub App slug via resolveConfiguredGitHubAppSlug() / getGitHubAppMention() instead of hard-coded @roomote

How it was tested

  • Unit test for slug injection in buildIssueFixerFixPrompt
  • Typecheck + pre-push green

Checklist

  • The PR title follows the repo convention
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • Added a focused unit test for the mention injection
  • I removed secrets, tokens, private keys, and customer data
  • If this change should appear in the changelog, I ran pnpm changeset

Use clearer clarifying-question and proposed-plan issue comments, with less
gh CLI ceremony in the prompt and skill.
@roomote-roomote

roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

  • packages/cloud-agents/src/server/issue-fixer-prompt.ts:97 and :109: The templates hard-code @roomote, but GitHub mention routing matches the deployment's configured app slug. This deployment uses @roomote-roomote, so replies following either template will not trigger the implementation task; inject the configured app mention instead.

Reviewed 2b59337

Inject resolveConfiguredGitHubAppSlug into Triage GitHub Issues comment
templates instead of hard-coding @roomote.
@mrubens
mrubens marked this pull request as ready for review July 18, 2026 23:36
@mrubens
mrubens merged commit 07052ff into develop Jul 18, 2026
17 checks passed
@mrubens
mrubens deleted the feature/triage-github-issues-prompt-format-30eaplnoe77tu branch July 18, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant