feat: support safe inline SVG widgets#566
Draft
daniel-lxs wants to merge 1 commit into
Draft
Conversation
Contributor
|
1 issue outstanding. See task
Reviewed e769432 |
daniel-lxs
force-pushed
the
codex/widget-no-svg-guidance
branch
from
July 18, 2026 20:58
8f77876 to
e769432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security boundary
Widgets remain scriptless and network-isolated. The iframe CSP continues to use
default-src 'none', while the worker sanitizer removes executable attributes and unsafe SVG elements or references before persistence.Validation
mise exec -- pnpm --filter @roomote/worker exec vitest run src/mcp/roomote-mcp-server/__tests__/show-widget.test.ts src/mcp/roomote-mcp-server/__tests__/tool-descriptions.test.tsmise exec -- pnpm --filter @roomote/worker check-typesmise exec -- pnpm --filter @roomote/worker lint