[Fix] Create Slack app button hard to see when disabled#547
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] Create Slack app button hard to see when disabled#547roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — internal fix from Slack feedback on Create Slack app button visibility.
Why this PR exists
What changed
Disabled primary buttons used
foreground/5for both background and text, so labels like Create Slack app were nearly invisible on the lime setup surface until a token was entered.Disabled default, destructive, secondary, and outline button styles now use stronger disabled contrast (
foreground/40text, slightly stronger fill/border) while remaining clearly inactive.Why this change was made
On self-hosted setup the Create Slack app control is correctly disabled with an empty token, but the old ultra-faint disabled styling made it look broken rather than waiting for input. This was not a light/dark mode bug — setup already forces light mode.
Impact
Users can still tell the button is disabled, but the label stays readable on light and high-chroma surfaces (including setup). Enabled button styling is unchanged.
How it was tested
pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/web exec vitest run src/components/system/primitives/button.test.tsxScreenshots
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset