[Fix] Environment boot failures show no useful error feedback#539
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] Environment boot failures show no useful error feedback#539roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Preserve Docker stderr when spawn fails, rewrite common boot failures into clear user-facing messages, and show still-booting elapsed time while waiting.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #538
Why this PR exists
What changed
When an environment fails while booting, the startup UI used to leave people on Booting environment with little context, then fail with a raw
docker run …command dump instead of the actual cause.This PR:
fetch failed, generic Docker command dumps)How it was tested
BaseController,docker-sandbox-security) and web (task-run-errors,StartupMessage.client)@roomote/controllerand@roomote/webChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetScreenshots