Rolemodel::ResourceFor::ControllerExtension - #205
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Rolemodel::ResourceFor::ControllerExtension, a small controller utility intended to simplify “child resources with many possible parents” by deriving the parent model and id param from route defaults (via routing concerns), and making the helper available across controllers through the engine.
Changes:
- Introduces
resource_foras a private controller method via a newControllerExtensionconcern. - Hooks the concern into
ActionController::Basevia a Rails engine initializer. - Adds request-level spec coverage and a README section documenting routing + controller usage and security considerations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spec/resource_for/controller_extension_spec.rb | Adds an integration-style request spec to validate routing-default behavior and availability of resource_for. |
| README.md | Documents the new controller extension, recommended routing pattern, and guidance for handling user-supplied types. |
| lib/rolemodel/resource_for/controller_extension.rb | Defines the ControllerExtension concern and resource_for helper. |
| lib/rolemodel/engine.rb | Loads and includes the controller extension into ActionController::Base via on_load. |
wesrich
approved these changes
Aug 4, 2026
justwiebe
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Rolemodel::ResourceFor::ControllerExtension, a small utility intended to simplify “child resources with many possible parents” by deriving the parent model and id param from route defaults (via routing concerns), and making the helper available across controllers through the engine.Pattern extracted from
TarscoBoltedTankWhat Changed?
resource_foras a private controller method via a newControllerExtensionconcern.ActionController::Basevia a Rails engine initializer.