Bump Node to 24 LTS so the release job's npm supports trusted publishing#170
Merged
Conversation
npm@latest is now npm 12, which requires Node >= 22.22.2 and fails EBADENGINE on the Node 22.17.1 pinned in .nvmrc. npm 11 supports trusted publishing (>= 11.5.1) and runs on Node ^20.17.0 || >=22.9.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fe296a0:
|
Node 24.18.0 bundles npm >= 11.5.1, which is all trusted publishing needs, so drop the global npm upgrade step from the release workflow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
RodrigoHamuy
changed the title
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job fails with
EBADENGINE(failing run): thenpm install -g npm@lateststep now resolves to npm 12, which doesn't support the Node 22.17.1 pinned in.nvmrc.Instead of juggling npm versions in CI, bump
.nvmrcto Node 24.18.0 (latest LTS), which bundles npm ≥ 11.5.1 — new enough for trusted publishing — and drop the global npm upgrade step from the release workflow entirely.🤖 Generated with Claude Code