FEAT: new actuator class for roll, throttle, and thrust vector control#965
Draft
zuorenchen wants to merge 1 commit into
Draft
FEAT: new actuator class for roll, throttle, and thrust vector control#965zuorenchen wants to merge 1 commit into
zuorenchen wants to merge 1 commit into
Conversation
…uash for RocketPy PR) (#7) * Merge RocketPy 1.12 and add updates for balloon popping challenge (zuorenchen#8) * Add actuator dynamics in TVC and ThrottleControl authored-by: RickyRicato <rickywang44@gmail.com> * Refactor actuator_tau parameters to use None as default in TVC and ThrottleControl authored-by: RickyRicato <rickywang44@gmail.com> * Add actuator dynamics to RollControl authored-by: RickyRicato <rickywang44@gmail.com> * Move actuators to a new actuator folder and rename actuator classes * Refactor roll, throttle, and thrust vector acutator with a new actuator class * Add pytest for all actuators * Update rocket.py and flight.py for actuator class update * Fix actuator class calls * Update active control example with new actuator class --------- Co-authored-by: RickyRicato <rickywang44@gmail.com>
Contributor
Author
TODO:
@Gui-FernandesBR @giovaniceotto do you want this in a continuous improvement approach (leave the TODOs in future PRs), or complete all TODOs in one PR? Feel free to send PRs to branch: /enh/actuator-merge-rocketpy in fork: ARRC-Rocket/ActiveRocketPy/ if you want to contribute more on this topic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
air_brakeis implemented as a controllerNew behavior
A new
Actuatorbase class is added.air_brakedemand_rate(a.k.a.sampling_rate) is discrete)demand_rate(a.k.a.sampling_rate) is discrete)Inheriting the
Actuatorbase class arethrottle: an actuator that applies a throttle gain value on top of motor thrust.roll: an actuator that applies a magic / hand-of-god roll torque on the rocketthrust vector: actuators that gimbal the motor thrust vector on x and y axisNew files:
/actuatorfolderhalcyon_flight_simModified files:
rocket.py: implement add_actuator methodsflight.py: apply actuators on the ODEsknown issue
Breaking change
Additional information
co-authored-by: RickyRicato rickywang44@gmail.com @chichunwang