fix: bound annotation geometry to assets - #693
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spatial annotations on assets with recorded dimensions now reject only when their geometry has no overlap with the asset frame. Partial boxes, paths, and polygons remain valid; classification annotations and assets without recorded dimensions retain their existing behavior.
Pre-labeling filters mapped model regions with no overlap before the atomic write, reports them separately from unmappable labels, and publishes that count through REST, CLI, MCP, and the completed-run dialog.
Validation
bash scripts/check.shThe full gate ran with Node 24.19.0 and covered Python tests, static checks, generated-artifact drift, frontend build/test/lint, Chromium end-to-end tests, and the real-server browser cycle.
Found, not fixed
None.
Closes #525