fix(deps): pin js-yaml past GHSA-5p4m-2wfm-xmqj - #569
Merged
Conversation
osv-scanner reported js-yaml 4.3.0 (GHSA-5p4m-2wfm-xmqj, CVSS 7.5) in the root lockfile. It arrives through openapi-typescript -> @redocly/openapi-core, which depends on js-yaml at an *exact* 4.3.0, so no `pnpm update` can move it -- a version-scoped override is the only lever. Scoped to `js-yaml@4.3.0` rather than a bare `js-yaml` override so it expires on its own: once @Redocly widens its pin, the entry stops matching and nothing is silently held back. docs-site's lockfile already resolves 4.3.1 and is untouched. `pnpm generate:client:check` is byte-identical, so the one consumer of the upgraded parser produces the same output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osv-scanner flags one vulnerability in this repo:
Why an override and not an update
js-yamlis transitive:openapi-typescript@7.13.0→@redocly/openapi-core@1.34.18→js-yaml. That last edge is an exact pin ("js-yaml": "4.3.0", not a range), sopnpm update -r --depth Infinity js-yamlresolves to the same version and leaves the lockfile byte-identical — verified before reaching for anything heavier. Apnpm.overridesentry is the only lever.The override is version-scoped (
js-yaml@4.3.0→4.3.1) rather than a barejs-yamlkey, so it expires on its own: the day@redoclywidens or bumps its pin, the entry stops matching and nothing is quietly held back at 4.3.1.docs-site/pnpm-lock.yamlalready resolves 4.3.1 (its dependent declares a range) and is untouched.Verification
osv-scanner scan --lockfile pnpm-lock.yaml→ No issues found (was 1 high).pnpm generate:client:check→ both generated files matchopenapi.json. This is the check that matters: openapi-typescript is the only consumer of the upgraded parser, and its output is a committed artifact.pnpm test:scripts→ 81 passed, 1 skipped, 0 failed.Scope
Two files, no source change, no UI surface, no new dependency.
Closes the Dependabot alert at
security/dependabot/7.