fix: pick the package name prefix per mutex, not per distro - #168
Conversation
Rolling publishes `ros2-<pkg>` for mutex 0.19 and published `ros-rolling-<pkg>` for everything before it, so a page-wide prefix left every older mutex at 0% available. Packages are now keyed by their bare name and the dataset records the prefix each mutex generation uses, which the table puts in front of every name it shows. The `ros-rolling-<pkg>` compatibility packages are dropped: they only pin the `ros2-<pkg>` of the same version and constrain no mutex, so counting them would advertise today's version on every older mutex too.
traversaro
left a comment
There was a problem hiding this comment.
Thanks! We are we tracking from which mutex a distro published names under the new scheme?
Yes. So for each mutex you check out the corresponding packages. |
Ah cool, so that works out of the box. |
Rolling publishes
ros2-<pkg>for mutex 0.19 and publishedros-rolling-<pkg>for everything before it. Since #166 the page picked one prefix per distro, so
on the older mutexes it looked up names that do not exist there and reported 0%
of the index available. Reported by @traversaro in #166.
ros2-rclcppandros-rolling-rclcppshare a row and each mutex slot comes from whichever spelling that generation
was built under
of every name it shows, so rows read
ros-rolling-rclcppon 0.16 to 0.18 andros2-rclcppon 0.19, links includedros-rolling-<pkg>compatibility packages: they only pin theros2-<pkg>of the same version and constrain no mutex, so counting themwould advertise today's version on every older mutex too
Screenshots
Rolling on
ros2-distro-mutex 0.18.0before, nothing available and every namespelled
ros2-:The same mutex after, back at 42% with the
ros-rolling-names it was builtunder:
How Has This Been Tested?
pixi run update-tables: rolling goes from 762 packages on 0.19 and nothingon any older mutex to 758, 756 and 755 on 0.18, 0.17 and 0.16, which is ~42%
of the index instead of 0%
to what is deployed today
pixi run lintandpixi run build-docs