fix: eliminate unbounded memory leak in sliding-window rate limiters - #216
Open
almuslavish wants to merge 1 commit into
Open
fix: eliminate unbounded memory leak in sliding-window rate limiters#216almuslavish wants to merge 1 commit into
almuslavish wants to merge 1 commit into
Conversation
Replace O(n) Array.shift() with batch filter() in both check() methods. Add cleanup() method to both limiters for proactive stale entry eviction. Add size getter to both limiters for memory observability. Add remove() method to createConnRateLimiter for API parity. The per-client rate limiter (1-second window) and per-IP connection rate limiter (60-second window) now: - Use batch filter() instead of shift() for O(1) amortized check() - Expose cleanup() to remove all stale entries in one pass - Expose size getter (windows.size) for monitoring - Remove keys entirely when no active timestamps remain Closes: issue-03-rate-limiter-memory-leak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #193
Replace O(n) Array.shift() with batch filter() in both check() methods. Add cleanup() method to both limiters for proactive stale entry eviction. Add size getter to both limiters for memory observability. Add remove() method to createConnRateLimiter for API parity.
The per-client rate limiter (1-second window) and per-IP connection rate limiter (60-second window) now:
Closes: issue-03-rate-limiter-memory-leak