Skip to content

Add chart loading shimmer (#213) - #266

Merged
arisu6804 merged 2 commits into
RemitFlow:mainfrom
Hollujay:feat/213-add-chart-loading-shimmer
Jul 24, 2026
Merged

Add chart loading shimmer (#213)#266
arisu6804 merged 2 commits into
RemitFlow:mainfrom
Hollujay:feat/213-add-chart-loading-shimmer

Conversation

@Hollujay

@Hollujay Hollujay commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a shimmer loading placeholder to the Chart component that displays while transfer data is being fetched.

Changes

src/components/Chart.jsx

  • Added loading prop (default false)
  • When loading is true, renders 8 animated shimmer bars with varying heights (45–85%) as a placeholder for the SVG chart
  • The download button area also shows a shimmer placeholder when loading
  • Container gets aria-busy={loading} for accessibility

src/components/Chart.css

  • Added .chart-shimmer — flex container with bottom-aligned bars matching the chart's bar layout
  • Added .chart-shimmer-bar — uses the existing skeleton-shimmer keyframes for the gradient animation, with rounded top corners
  • Added .chart-shimmer-btn — placeholder for the download button
  • Respects prefers-reduced-motion (disables animation) and prefers-contrast: more (solid border instead of gradient)

src/pages/Transfers.jsx

  • Renders <Chart loading> inside the loading block so the chart shimmer appears alongside the existing Skeleton rows

test/components/Chart.test.jsx

  • Added test verifying shimmer renders with aria-busy="true", .chart-shimmer, and .chart-shimmer-btn

Related

Closes #213

@arisu6804

Copy link
Copy Markdown
Contributor

Nice one, well scoped. 👏

@arisu6804

Copy link
Copy Markdown
Contributor

Well done, thanks! ⭐

@arisu6804

Copy link
Copy Markdown
Contributor

Great work! 🙌

@arisu6804
arisu6804 merged commit e33b5f9 into RemitFlow:main Jul 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a chart loading shimmer

2 participants