Show pass counts in test runner module rows#1576
Merged
Merged
Conversation
Module rows in the test viewer showed only the total test count, so a module with a single failure read the same as one that failed entirely. After a run they now show passed/total, e.g. 'Gui (12/17)'. Modules with no results yet keep the plain total. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module rows in the in-game test viewer showed only the total test count, so a module with a single failure read the same as one that failed entirely — e.g. a red
Gui (17)where 12 of the 17 actually passed.After a run, module rows now show
passed/total, e.g.Gui (12/17). Modules with no results yet keep the plain total, so an unrun module doesn't misleadingly read as0/17.Implementation:
mark_module_for_passedin the runner already walks the module tree after every run to set the pass/fail colouring, so it now also tallies passed and ran tests per module in the same pass. The viewer uses the tally when present.Before
After
🤖 Generated with Claude Code